Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support state change subscription #40

Closed
wants to merge 2 commits into from
Closed

Conversation

i-norden
Copy link
Collaborator

@i-norden i-norden commented Mar 19, 2021

Needs release with vulcanize/ipld-eth-indexer#81

Ideally we would create a new Postgres trigger to collect and package all of the data required for the payload from inside Postgres (from across the header_cids, state_cids, storage_cids, and IPLD blocks tables), but this implementation uses the current triggers written for Postgraphile to collect the header ID on a new header insert and then round-trips to the DB to collect the payload data from those four tables.

Still needs test.

@i-norden i-norden force-pushed the support_subscribe branch 3 times, most recently from fc69e9c to bed13b9 Compare March 19, 2021 16:14
@AFDudley
Copy link
Contributor

@yaoandrew Please review

@i-norden i-norden force-pushed the support_subscribe branch from bed13b9 to d7b826b Compare March 19, 2021 18:03
@AFDudley
Copy link
Contributor

This is a feature requested by the 8th light team, but I think it also fits in with our current work around removing postgraphile so I wanted to bring it to @ashwinphatak's attention.

@yaoandrew
Copy link
Contributor

This is a feature requested by the 8th light team, but I think it also fits in with our current work around removing postgraphile so I wanted to bring it to @ashwinphatak's attention.

Hi guys... I'm sorry, I think I may have had a [text] miscommunication with Rick, but if you want to support getting state changes in your stack from our State Diffing node, that's great. We originally thought we could get away from using our fork of geth and utilize the tracing API, but now I don't think that's possible. We plan to continue keeping this fork up to date for the time being.

@ecmendenhall
Copy link

Appreciate this work! The enhancements y'all have been working on are impressive. I'll pull this and the other dependencies and see if we can plug into this as our statediffing subscription source.

@arijitAD arijitAD closed this Jun 26, 2021
@arijitAD arijitAD deleted the support_subscribe branch June 26, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants