This repository has been archived by the owner on May 22, 2024. It is now read-only.
[terra-clinical-item-view] Accessibility guide #916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RayGunY
force-pushed
the
UXPLATFORM-8569
branch
from
ac0d436 to
40e3758
Compare
jfrhong
reviewed
Sep 14, 2023
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
8 tasks
sdadn
suggested changes
Sep 21, 2023
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Show resolved
Hide resolved
| Displays in the Item View are rendered as list items inside a primary unordered list. | ||
| The structure is different for the different types of layouts - one column, two columns, and two columns by row. Their structure is as follows: | ||
|
|
||
| **For a one column layout with 8 displays** |
There was a problem hiding this comment.
I wonder if we can display these 3 lists as side by side for better comparison.
There was a problem hiding this comment.
I played around with it a bit, does this seem better? Haven't pushed out the change yet
There was a problem hiding this comment.
I can also top align them
There was a problem hiding this comment.
Sweet, added here: 5e73fd5
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
RayGunY
force-pushed
the
UXPLATFORM-8569
branch
from
11891a9 to
e5cfead
Compare
sdadn
reviewed
Sep 22, 2023
...ra-clinical-item-view/src/terra-dev-site/doc/clinical-item-view/AccessibilityGuide.4.doc.mdx
Outdated
Show resolved
Hide resolved
sycombs
reviewed
Sep 22, 2023
jfrhong
approved these changes
Sep 25, 2023
| - For example - presenting related information across from each other in the two column view can make it more difficult for users to understand that the information is related. | ||
| Reading by column from top to bottom is the more common way information is consumed visually, so when presenting this information by row between the two columns it might be confusing for assistive technology users and users in general. | ||
| - When passing in Clinical Item Displays, keep in mind that only 8 can be used within a view at a time. Any additional displays passed in will be ignored. | ||
| - Displays are also split between two columns with every other display being moved to the right hand column. |
There was a problem hiding this comment.
Should this be more like "When displays are split into two columns, every other display is in the right hand column"? Also, again seems like something useful to know in the props
There was a problem hiding this comment.
Slightly reworded this and added the info to the layout prop since I think that's more relevant than putting it under the display prop. facd8ef
sdadn
approved these changes
Sep 25, 2023
RayGunY
force-pushed
the
UXPLATFORM-8569
branch
from
facd8ef to
9d923a5
Compare
sycombs
approved these changes
Sep 27, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
What was changed:
Added an accessibility guide for Clinical Item View
Why it was changed:
So users have a reference for accessibility guidelines and changes we've made to the component.
Testing
This change was tested using:
Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-8569
Thank you for contributing to Terra.
@cerner/terra