This repository has been archived by the owner on May 22, 2024. It is now read-only.
Replace .npmignores with file field
#926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Is there any way we can test this with terra-ui before releasing? (To ensure that we've whitelisted all the files needed for the site to build.) |
|
This issue has been automatically marked as inactive because it has not had recent activity. It will be closed in seven days if no further activity occurs. Thank you for your contributions. |
@sycombs Good call! Used
|
sycombs
approved these changes
Feb 14, 2024
nikhitasharma
approved these changes
Feb 14, 2024
CHANGELOG updates are not needed. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces
.npmignorefiles with thefilesprop to denote what files will be published. The.npmignoreworks by blacklisting files, whilefilesworks by whitelisting files to be published. This change was made as it is more convenient to keep track of files that need to be published than finding potential files that don't need to be published. It also results in fewer issues when runningnpm packlocally.Testing
This change was tested using:
This was tested by running
npm packonterra-clinical-headerand verifying that all necessary files are included:Reviews
In addition to engineering reviews, this PR needs:
Additional Details
This PR resolves:
UXPLATFORM-XXXX
Thank you for contributing to Terra.
@cerner/terra