further simplify ContentPolicy::edit

cerpus · Jan 8, 2025 · e59dd1a · e59dd1a
1 parent 925626f
commit e59dd1a
Showing 1 changed file with 8 additions and 14 deletions.
diff --git a/sourcecode/hub/app/Policies/ContentPolicy.php b/sourcecode/hub/app/Policies/ContentPolicy.php
@@ -58,23 +58,17 @@ public function edit(
             return true;
         }
 
-        if ($content->hasUserWithMinimumRole($user, ContentRole::Editor)) {
-            return true;
-        }
-
         $platform = $this->getLtiPlatform();
 
-        if ($platform) {
-            if (
-                $platform->authorizes_edit &&
-                $this->request->session()->has('intent-to-edit.' . $content->id)
-            ) {
-                return true;
-            }
+        if (
+            $platform?->authorizes_edit &&
+            $this->request->session()->has('intent-to-edit.' . $content->id)
+        ) {
+            return true;
+        }
 
-            if ($this->hasContentRole(ContentRole::Editor, $content, $user, $platform)) {
-                return true;
-            }
+        if ($this->hasContentRole(ContentRole::Editor, $content, $user, $platform)) {
+            return true;
         }
 
         return false;