Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

only forward resize messages in embed view #2807

Merged
merged 1 commit into from
Nov 27, 2024

Conversation

emmachughes
Copy link
Member

@emmachughes emmachughes commented Nov 27, 2024

This fixes a bug where e.g. previewing content that emits resize messages would signal to Edlib's parent frame that Edlib must be resized, even as Edlib is currently displaying more than just the content.

The @props rubbish is removed, as it interferes with $attributes.

Fixes #2804

@emmachughes emmachughes requested a review from chrieinv November 27, 2024 11:32
@emmachughes emmachughes linked an issue Nov 27, 2024 that may be closed by this pull request
@emmachughes emmachughes changed the base branch from edlib3 to master November 27, 2024 12:07
@emmachughes emmachughes merged commit fb03924 into master Nov 27, 2024
5 checks passed
@emmachughes emmachughes deleted the conditionally-forward-resize-messages branch November 27, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stop forwarding resize messages
2 participants