Update "Setting Nameservers for DNS01 Self Check" example

[Skulblaka]

I tried to apply the example for configuration alternative servers used for the DNS01 self check, since I'm having trouble with that on my DigitalOcean managed cluster.

Here are the commands I ran:

kubectl apply -f https://github.com/jetstack/cert-manager/releases/download/v1.3.0/cert-manager.yaml
kubectl --namespace cert-manager patch --type json deployment cert-manager -p "$(cat cert-manager.patch.json)"

cert-manager.patch.json:

[
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers-only"
  },
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers=\"8.8.8.8:53,1.1.1.1:53\""
  }
]

I get a Crashloopbackoff from the cert-manager pod however: Error: error validating options: invalid DNS server (address 8.8.8.8:53,1.1.1.1:53: too many colons in address): 8.8.8.8:53,1.1.1.1:53

After changing my patch to like the following it worked as expected:

[
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers-only"
  },
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers=\"8.8.8.8:53\""
  },
  {
    "op": "add",
    "path": "/spec/template/spec/containers/0/args/-",
    "value": "--dns01-recursive-nameservers=\"1.1.1.1:53\""
  }
]

I guess the "Comma separated string" part isn't valid anymore.

[jetstack-bot]

Hi @Skulblaka. Thanks for your PR.

I'm waiting for a cert-manager member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jetstack-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Skulblaka
To complete the pull request process, please assign jakexks after the PR has been reviewed.
You can assign the PR to them by writing /assign @jakexks in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jetstack-bot]

@Skulblaka: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.