Fix LevelDB yaml unmarshall error and update documentation #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to ensure the project correctly validates authentication methods in the config file that can use a token db, this commit modifies the logic to ensure we check if all of the token methods are nil before outputting an error. Previously, if the local filesystem token db method was not nil and the other two (redis and google cloud storage) were nil, we would return an error and the config would be considered invalid. Additionally, this commit documents the correct LevelDB settings for the config file. Prior to the addition of Bcrypt hashing cost, just using `token_db` was acceptable in the configuration along with a string representing the path. Given the swap to a struct instead of a string, we need to update documentation concerning this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to ensure the project correctly validates authentication methods in the config file that can use a token db, this commit modifies the logic to ensure we check if all of the token methods are nil before outputting an error. Previously, if the local filesystem token db method was not nil and the other two (redis and google cloud storage) were nil, we would return an error and the config would be considered invalid.
Additionally, this commit documents the correct LevelDB settings for the config file. Prior to the addition of Bcrypt hashing cost, just using
token_dbwas acceptable in the configuration along with a string representing the path. Given the swap to a struct instead of a string, we need to update documentation concerning this.