Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change from pagination to scroll on badgedex #578

Merged
merged 11 commits into from
Dec 7, 2023

Conversation

Darguima
Copy link
Contributor

@Darguima Darguima commented Nov 24, 2023

Added a fallback image to the Badges, when the url one isn't available (on the video all them are the fallback)
Added Empty badges message.
Added Infinite Scroll (with a Go To Top button)

2023-11-24.21-03-55.mp4

[EDIT] - changed video to also have the sliding effect on the button

Copy link

netlify bot commented Nov 24, 2023

Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit 95dc243
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/657203f393ef8b0008214c0e
😎 Deploy Preview https://deploy-preview-578--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Darguima Darguima changed the title Infinite Scroll Badgedex feat: Infinite Scroll Badgedex Nov 24, 2023
@Darguima Darguima linked an issue Nov 24, 2023 that may be closed by this pull request
@Darguima Darguima self-assigned this Nov 24, 2023
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use this badge image instead?

image

@Darguima
Copy link
Contributor Author

I already edited, but the 404 have a buggy shadow

image

@Darguima
Copy link
Contributor Author

Fixed

image

Co-authored-by: Rui Lopes <[email protected]>
@Darguima Darguima requested a review from ruilopesm November 25, 2023 22:50
Copy link
Member

@ruilopesm ruilopesm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 🙌🏼
In fact, this is not an infinite scroll, as the content is not being loaded as I scroll down. However, I feel that approach is over complicated and not necessary here. Anyway, I think we should implement a skeleton rendering for when a badge is rendering - can you handle that? 💪🏼

@ruilopesm ruilopesm changed the title feat: Infinite Scroll Badgedex refactor: change from pagination to scroll on badgedex Nov 27, 2023
@Darguima
Copy link
Contributor Author

Darguima commented Dec 4, 2023

Great work 🙌🏼 In fact, this is not an infinite scroll, as the content is not being loaded as I scroll down. However, I feel that approach is over complicated and not necessary here. Anyway, I think we should implement a skeleton rendering for when a badge is rendering - can you handle that? 💪🏼

Done. Any suggestions or any already existing color schema on the project that I can use here for the skeleton?

Also, I suggest you to try because the video is a little bit confusing on the transition due quick access to the image.

2023-12-04.01-38-39.mp4

@Darguima
Copy link
Contributor Author

Darguima commented Dec 6, 2023

I fixed that delay showing the fallback image after the skeleton. Also fixed the infinite loop fallback.

@Darguima Darguima requested a review from ruilopesm December 6, 2023 11:45
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work, thank you! 🙇🚀

@joaodiaslobo joaodiaslobo merged commit 4152abe into main Dec 7, 2023
4 checks passed
@joaodiaslobo joaodiaslobo deleted the dg/infinite_scroll_badgedex branch December 7, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement infinite scroll on badgedex page
3 participants