-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: change from pagination to scroll on badgedex #578
Conversation
✅ Deploy Preview for seium-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Rui Lopes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🙌🏼
In fact, this is not an infinite scroll, as the content is not being loaded as I scroll down. However, I feel that approach is over complicated and not necessary here. Anyway, I think we should implement a skeleton rendering for when a badge is rendering - can you handle that? 💪🏼
Done. Any suggestions or any already existing color schema on the project that I can use here for the skeleton? Also, I suggest you to try because the video is a little bit confusing on the transition due quick access to the image. 2023-12-04.01-38-39.mp4 |
I fixed that delay showing the fallback image after the skeleton. Also fixed the infinite loop fallback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outstanding work, thank you! 🙇🚀
Added a fallback image to the Badges, when the url one isn't available (on the video all them are the fallback)
Added Empty badges message.
Added Infinite Scroll (with a Go To Top button)
2023-11-24.21-03-55.mp4
[EDIT] - changed video to also have the sliding effect on the button