feat: speakers open animation #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarioRodrigues10
requested review from
joaodiaslobo,
Darguima,
ruioliveira02,
tiago-bacelar and
ruilopesm
✅ Deploy Preview for seium-stg ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Darguima
approved these changes
Nov 24, 2023
tiago-bacelar
requested changes
Nov 24, 2023
| <p className={showSpeaker ? "hidden" : ""}>{description}</p> | ||
| <div> | ||
| <p | ||
| className={`transition-max-height overflow-hidden duration-300 max-h-${ |
There was a problem hiding this comment.
Suggested change
| className={`transition-max-height overflow-hidden duration-300 max-h-${ | |
| className={`transition-max-height overflow-hidden duration-300 ${showSpeaker ? "max-h-96" : "max-h-0"}`} |
Reason: tailwind analyses all source files to find css classes to avoid outputting the whole library. By splitting up the css class name, this analysis won't find it. The only reason why the animation still works in this case is because this exact same class is found in another source file (in the schedule, where it's used for the exact same animation)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.