Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: speakers open animation #581

Merged
merged 1 commit into from
Nov 24, 2023
+9 −2
Merged

feat: speakers open animation #581

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions layout/Speakers/components/Schedule/Table/Block/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,8 +91,15 @@ export default function Block({
</div>
</div>
</div>

<p className={showSpeaker ? "hidden" : ""}>{description}</p>
<div>
<p
className={`transition-max-height overflow-hidden duration-300 max-h-${
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
className={`transition-max-height overflow-hidden duration-300 max-h-${
className={`transition-max-height overflow-hidden duration-300 ${showSpeaker ? "max-h-96" : "max-h-0"}`}

Reason: tailwind analyses all source files to find css classes to avoid outputting the whole library. By splitting up the css class name, this analysis won't find it. The only reason why the animation still works in this case is because this exact same class is found in another source file (in the schedule, where it's used for the exact same animation)

showSpeaker ? "0" : "96"
}`}
>
{description}
</p>
</div>
</div>
);
}
Loading