Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: alignment issue of place under the award section #582

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: alignment issue of place under the award section #582

merged 1 commit into from
Dec 18, 2023

Conversation

ShashwatPS
Copy link
Contributor

Fixed the alignment issue of place under the award section in the Challenges page.

Fixes #511

Copy link

netlify bot commented Nov 25, 2023

Deploy Preview for seium-stg ready!

Name Link
🔨 Latest commit f82a260
🔍 Latest deploy log https://app.netlify.com/sites/seium-stg/deploys/657f0f4c8a397200080dae92
😎 Deploy Preview https://deploy-preview-582--seium-stg.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ruilopesm ruilopesm changed the title fix: fixed the alignment issue of place under the award section. fix: alignment issue of place under the award section Nov 25, 2023
@ruilopesm ruilopesm self-requested a review November 25, 2023 14:09
@ShashwatPS
Copy link
Contributor Author

Is there some issue with my code, do i need to fix anything ? @ruilopesm

@diogogmatos
Copy link
Member

Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works and makes it look exactly like we want, thank you! 🙇
However, this project uses Tailwind CSS, and we prefer to use it instead of normal CSS styling.
So, if you can, remove the style attributes and use the library's class names to syle items.

@ShashwatPS ShashwatPS closed this Dec 9, 2023
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding work, thank you! 🙇🚀

@joaodiaslobo joaodiaslobo merged commit 0292326 into cesium:main Dec 18, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align "place" on awards listing
3 participants