Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove api versioning #348

Merged
merged 2 commits into from
Nov 4, 2023
Merged

refactor: remove api versioning #348

merged 2 commits into from
Nov 4, 2023

Conversation

joaodiaslobo
Copy link
Member

Removes version identifier from the API endpoints. Fixes #347

@joaodiaslobo joaodiaslobo self-assigned this Nov 4, 2023
@joaodiaslobo joaodiaslobo mentioned this pull request Nov 4, 2023
Merged
MarioRodrigues10
MarioRodrigues10 requested changes Nov 4, 2023
View reviewed changes
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change also the 'v1' in safira/lib/safira_web/cors.ex

MarioRodrigues10
MarioRodrigues10 approved these changes Nov 4, 2023
View reviewed changes
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job ! 👍

@joaodiaslobo joaodiaslobo merged commit dad48ff into master Nov 4, 2023
2 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/improve-api-endpoints branch November 4, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarioRodrigues10 MarioRodrigues10 MarioRodrigues10 approved these changes

@Darguima Darguima Awaiting requested review from Darguima

@ruioliveira02 ruioliveira02 Awaiting requested review from ruioliveira02

@tiago-bacelar tiago-bacelar Awaiting requested review from tiago-bacelar

@EnzoVieira EnzoVieira Awaiting requested review from EnzoVieira

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

Assignees

@joaodiaslobo joaodiaslobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove v1 from API endpoints
2 participants
@joaodiaslobo @MarioRodrigues10