Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change managers to staffs #354

Merged
merged 5 commits into from
Nov 9, 2023
Merged

chore: change managers to staffs #354

merged 5 commits into from
Nov 9, 2023

Conversation

MarioRodrigues10
Copy link
Member

@MarioRodrigues10 MarioRodrigues10 commented Nov 9, 2023 •
edited
Loading

This PR solves #344 .

@MarioRodrigues10 MarioRodrigues10 added this to the SEI '24 milestone Nov 9, 2023
@MarioRodrigues10 MarioRodrigues10 self-assigned this Nov 9, 2023
@MarioRodrigues10 MarioRodrigues10 mentioned this pull request Nov 9, 2023
Merged
joaodiaslobo
joaodiaslobo requested changes Nov 9, 2023
View reviewed changes
.tool-versions Outdated Show resolved Hide resolved
joaodiaslobo
joaodiaslobo requested changes Nov 9, 2023
View reviewed changes
lib/safira_web/cors.ex Outdated Show resolved Hide resolved
joaodiaslobo
joaodiaslobo requested changes Nov 9, 2023
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change 20220121123022_add_admin_to_manager.exs to 20220121123022_add_admin_to_staff.exs

joaodiaslobo
joaodiaslobo approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@joaodiaslobo joaodiaslobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 💪

@MarioRodrigues10 MarioRodrigues10 merged commit b6ce036 into master Nov 9, 2023
2 checks passed
@MarioRodrigues10 MarioRodrigues10 deleted the mr/rename-managers-to-staffs branch November 9, 2023 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaodiaslobo joaodiaslobo joaodiaslobo approved these changes

@Darguima Darguima Awaiting requested review from Darguima

@ruioliveira02 ruioliveira02 Awaiting requested review from ruioliveira02

@tiago-bacelar tiago-bacelar Awaiting requested review from tiago-bacelar

@EnzoVieira EnzoVieira Awaiting requested review from EnzoVieira

@ruilopesm ruilopesm Awaiting requested review from ruilopesm

Assignees

@MarioRodrigues10 MarioRodrigues10

Labels
None yet
Projects
None yet
Milestone
SEI '24
Development

Successfully merging this pull request may close these issues.
2 participants
@MarioRodrigues10 @joaodiaslobo