Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add course to attendee #359

Merged
merged 10 commits into from
Nov 29, 2023
Merged

feat: add course to attendee #359

merged 10 commits into from
Nov 29, 2023

Conversation

joaodiaslobo
Copy link
Member

Fix #341

@joaodiaslobo
Copy link
Member Author

priv/fake/courses.txt Outdated Show resolved Hide resolved
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we want to normalize the database? To do so, we would need to create a table with all the courses. With that, there would be no need to duplicate this data in the frontend, which could just call the API to get all available courses.

@joaodiaslobo
Copy link
Member Author

joaodiaslobo commented Nov 27, 2023

Don't we want to normalize the database? To do so, we would need to create a table with all the courses. With that, there would be no need to duplicate this data in the frontend, which could just call the API to get all available courses.

@ruioliveira02 That's totally something that I can do, I'm just a bit unsure about that implementation because that would involve making an API call every time someone opens the sign up page

@ruilopesm
Copy link
Member

@joaodiaslobo you could use, on the frontend, getServerSideProps from Next.js, in order to cache it within different clients.

@joaodiaslobo
Copy link
Member Author

@joaodiaslobo you could use, on the frontend, getServerSideProps from Next.js, in order to cache it within different clients.

@ruilopesm Thanks, I'll see what I can do! 💪

ruilopesm
ruilopesm previously approved these changes Nov 29, 2023
@joaodiaslobo joaodiaslobo merged commit 8e3ed94 into master Nov 29, 2023
2 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/add-course-to-attendee branch November 29, 2023 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add course to user
3 participants