Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: landing #406

Merged
merged 28 commits into from
Jan 6, 2025
Merged

feat: landing #406

merged 28 commits into from
Jan 6, 2025

Conversation

joaodiaslobo
Copy link
Member

@joaodiaslobo joaodiaslobo commented Oct 14, 2024 •
edited
Loading

Solves #407
image

@joaodiaslobo joaodiaslobo self-assigned this Oct 14, 2024
@joaodiaslobo joaodiaslobo marked this pull request as ready for review January 5, 2025 04:09
ruioliveira02
ruioliveira02 reviewed Jan 5, 2025
View reviewed changes
Copy link
Member

@ruioliveira02 ruioliveira02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'meet the team' and 'meet the speakers' buttons should not appear right now, as they lead to a 404.

I think that, for dev, we should have a default company logo

lib/safira_web/components/layouts/root.html.heex Outdated Show resolved Hide resolved
lib/safira_web/components/layouts/landing.html.heex Outdated Show resolved Hide resolved
lib/safira_web/config.ex Show resolved Hide resolved
lib/safira_web/live/landing/components/join_us.ex Outdated Show resolved Hide resolved
lib/safira_web/live/landing/home_live/components/sponsors.ex Show resolved Hide resolved
lib/safira_web/live/landing/home_live/index.ex Show resolved Hide resolved
lib/safira_web/live/landing/faqs_live/components/find_us.ex Outdated Show resolved Hide resolved
@joaodiaslobo joaodiaslobo merged commit 96564b5 into main Jan 6, 2025
2 checks passed
@joaodiaslobo joaodiaslobo deleted the jl/landing branch January 6, 2025 00:04
This was referenced Jan 9, 2025
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruioliveira02 ruioliveira02 ruioliveira02 approved these changes

@nunom27 nunom27 Awaiting requested review from nunom27

@Darguima Darguima Awaiting requested review from Darguima

@MarioRodrigues10 MarioRodrigues10 Awaiting requested review from MarioRodrigues10

@AfonsoMartins26 AfonsoMartins26 Awaiting requested review from AfonsoMartins26

Assignees

@joaodiaslobo joaodiaslobo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joaodiaslobo @ruioliveira02