feat: block routes based on event start time #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruioliveira02
force-pushed
the
ro/start-time
branch
2 times, most recently
from
5e01381 to
f89703b
Compare
ruioliveira02
force-pushed
the
ro/start-time
branch
from
f89703b to
bfb143d
Compare
MarioRodrigues10
requested changes
Nov 10, 2024
|
In case start_time is |
MarioRodrigues10
requested changes
Nov 18, 2024
Comment on lines
64
to
65
| Event.change_registrations_open(string_to_bool(params["registrations_open"])) | ||
| Event.change_event_start_time(parse_date(params["start_time"])) |
There was a problem hiding this comment.
What if this doesn't return :ok
ruioliveira02
force-pushed
the
ro/start-time
branch
from
c2ebb6b to
0f07176
Compare
MarioRodrigues10
requested changes
Nov 20, 2024
Co-authored-by: Mário Rodrigues <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.