Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor Update: Circular Paths & updates #204

Merged
merged 13 commits into from
Nov 5, 2023
Merged

Minor Update: Circular Paths & updates #204

merged 13 commits into from
Nov 5, 2023

Conversation

maede97
Copy link
Member

@maede97 maede97 commented Oct 4, 2023

  • Circular Paths in KML are now supported
  • Dependencies updated
  • Readme updates

maede97 and others added 8 commits October 3, 2023 20:10
@maede97
Update index.html (#197)
7fe47bf 
Translate the english title to german (short variant instead of "Automatisierte Marschzeittabellen")
@dependabot @wp99cp
Bump socket.io-parser from 4.2.2 to 4.2.4 in /frontend (#195)
4ef496c 
Bumps [socket.io-parser](https://github.com/socketio/socket.io-parser) from 4.2.2 to 4.2.4.
- [Release notes](https://github.com/socketio/socket.io-parser/releases)
- [Changelog](https://github.com/socketio/socket.io-parser/blob/main/CHANGELOG.md)
- [Commits](socketio/socket.io-parser@4.2.2...4.2.4)

---
updated-dependencies:
- dependency-name: socket.io-parser
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Cyrill Püntener <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @wp99cp
Bump vite from 3.2.4 to 3.2.7 in /docs (#194)
c5e6044 
Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 3.2.4 to 3.2.7.
- [Release notes](https://github.com/vitejs/vite/releases)
- [Changelog](https://github.com/vitejs/vite/blob/v3.2.7/packages/vite/CHANGELOG.md)
- [Commits](https://github.com/vitejs/vite/commits/v3.2.7/packages/vite)

---
updated-dependencies:
- dependency-name: vite
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Cyrill Püntener <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@maede97 @wp99cp
Update Readme.md (#198)
2df6c14 
Add german dev notes to readme

Co-authored-by: Cyrill Püntener <[email protected]>
@maede97
Fix Issue 138 & Cypress ENV (#199)
5a18134 
* Fix issue 138

* fix cypress env var
@dependabot
Bump pillow from 9.3.0 to 10.0.1 in /swiss_TLM_api (#203)
748a91d
@maede97
add parser for circular kml files (#200)
52f152c
@maede97
bump version
bc1d6f6
@wp99cp wp99cp self-requested a review October 5, 2023 11:35
wp99cp
wp99cp requested changes Oct 5, 2023
View reviewed changes
Copy link
Member

@wp99cp wp99cp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dev Deployment crashes with the backend container reporting:

Exception in thread Thread-2 (create_export):
Traceback (most recent call last):
  File "/usr/local/lib/python3.11/threading.py", line 1038, in _bootstrap_inner
    self.run()
  File "/usr/local/lib/python3.11/threading.py", line 975, in run
    self._target(*self._args, **self._kwargs)
  File "/app/app.py", line 210, in create_export
    options['print-api-base-url'] = os.environ['PRINT_API_BASE_URL']
                                    ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
  File "<frozen os>", line 679, in __getitem__
KeyError: 'PRINT_API_BASE_URL'

I also opened #206

@wp99cp wp99cp mentioned this pull request Oct 5, 2023
Closed
@maede97
Copy link
Member Author

maede97 commented Oct 9, 2023

@wp99cp has the deployment a different env file?

dependabot bot and others added 2 commits October 10, 2023 19:54
@dependabot @wp99cp
Bump postcss from 8.4.19 to 8.4.31 in /docs (#208)
14f932b 
Bumps [postcss](https://github.com/postcss/postcss) from 8.4.19 to 8.4.31.
- [Release notes](https://github.com/postcss/postcss/releases)
- [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md)
- [Commits](postcss/postcss@8.4.19...8.4.31)

---
updated-dependencies:
- dependency-name: postcss
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Cyrill Püntener <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @wp99cp
Bump pillow from 9.3.0 to 10.0.1 in /swiss_TLM_api (#205)
0f36d42 
Bumps [pillow](https://github.com/python-pillow/Pillow) from 9.3.0 to 10.0.1.
- [Release notes](https://github.com/python-pillow/Pillow/releases)
- [Changelog](https://github.com/python-pillow/Pillow/blob/main/CHANGES.rst)
- [Commits](python-pillow/Pillow@9.3.0...10.0.1)

---
updated-dependencies:
- dependency-name: pillow
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Cyrill Püntener <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@maede97
Copy link
Member Author

maede97 commented Oct 10, 2023

For me locally, the ENV file is successfully loaded and works as intended...

@wp99cp
Copy link
Member

wp99cp commented Oct 15, 2023

The hosted version has both the dev and prod instances and no environment files configured.
It seems that they aren't needed until now?

I will update the deployment process and add the environment variable. Will update you as soon as that is done (it will take some time...)

@maede97
Copy link
Member Author

maede97 commented Nov 3, 2023

I will update the deployment process and add the environment variable. Will update you as soon as that is done (it will take some time...)

Any update on this?

wp99cp
wp99cp previously approved these changes Nov 5, 2023
View reviewed changes
@maede97 maede97 merged commit 70ba73b into master Nov 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wp99cp wp99cp wp99cp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maede97 @wp99cp