Avoid unnecessary Uint8List instantiations

cfug · Nov 14, 2023 · 33ddefe · 33ddefe
1 parent c74941f
commit 33ddefe
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/dio/lib/src/adapter.dart b/dio/lib/src/adapter.dart
@@ -75,7 +75,9 @@ class ResponseBody {
     this.statusMessage,
     this.isRedirect = false,
     Map<String, List<String>>? headers,
-  })  : stream = Stream.value(Uint8List.fromList(bytes)),
+  })  : stream = Stream.value(
+          bytes is Uint8List ? bytes : Uint8List.fromList(bytes),
+        ),
         headers = headers ?? {};
 
   /// Whether this response is a redirect.

diff --git a/dio/lib/src/adapters/io_adapter.dart b/dio/lib/src/adapters/io_adapter.dart
@@ -200,7 +200,10 @@ class IOHttpClientAdapter implements HttpClientAdapter {
     }
 
     int dataLength = 0;
-    final stream = responseStream.transform<Uint8List>(
+
+    /// Casting the stream to Uint8List is safe due to [_HttpClientResponse]
+    /// working on a Uint8List.
+    final stream = responseStream.cast<Uint8List>().transform<Uint8List>(
       StreamTransformer.fromHandlers(
         handleData: (data, sink) {
           if (cancellation != null) {
@@ -226,7 +229,7 @@ class IOHttpClientAdapter implements HttpClientAdapter {
             dataLength += data.length,
             responseStream.contentLength,
           );
-          sink.add(Uint8List.fromList(data));
+          sink.add(data);
         },
       ),
     );