Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve exceptions and documents for FormData and MultipartFile #1714

Merged
merged 3 commits into from
Mar 6, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Mar 6, 2023

Help issues like #482 to understand what happened exactly.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

As an improvement with comments and docs, it doesn't require a version change.

@AlexV525 AlexV525 requested a review from a team as a code owner March 6, 2023 11:22
@AlexV525 AlexV525 force-pushed the improve-form-data-and-multipart-file branch from 2d3c1ab to e15ed03 Compare March 6, 2023 12:34
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some textual improvements, otherwise LGTM.

dio/lib/src/form_data.dart Outdated Show resolved Hide resolved
dio/lib/src/multipart_file.dart Outdated Show resolved Hide resolved
Co-authored-by: Peter Leibiger <[email protected]>
Signed-off-by: Alex Li <[email protected]>
@AlexV525 AlexV525 merged commit 8a00f8d into main Mar 6, 2023
@AlexV525 AlexV525 deleted the improve-form-data-and-multipart-file branch March 6, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants