Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cookie_manager] Fix FileSystemException when saving redirect cookies without a proper host #1948

Merged
merged 9 commits into from
Oct 1, 2023
Merged

[cookie_manager] Fix FileSystemException when saving redirect cookies without a proper host #1948

Changes from 3 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
350a08b
Fixes `FileSystemException: Cannot open file ... (OS Error: Is a dire…
s0nerik Aug 31, 2023
4ec39c3
Fixes `FileSystemException: Cannot open file ... (OS Error: Is a dire…
s0nerik Aug 31, 2023
2220c26
Fixes `FileSystemException: Cannot open file ... (OS Error: Is a dire…
s0nerik Aug 31, 2023
10755a9
Added a test to verify that CookieJar.saveFromResponse() is called wi…
s0nerik Sep 1, 2023
326e1c2
Updated CHANGELOG.md
s0nerik Sep 1, 2023
b81020a
Added another test for `CookieJar.saveFromResponse()`
s0nerik Sep 1, 2023
c26840c
Update CHANGELOG.md
s0nerik Sep 29, 2023
af40b43
📝 Add spec comment
AlexV525 Oct 1, 2023
2c4db02
✅ Group tests
AlexV525 Oct 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugins/cookie_manager/lib/src/cookie_mgr.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,9 @@ class CookieManager extends Interceptor {
// users will be available to handle cookies themselves.
final isRedirectRequest = statusCode >= 300 && statusCode < 400;
// Saving cookies for the original site.
await cookieJar.saveFromResponse(response.realUri, cookies);
final originalUri = response.requestOptions.uri;
final realUri = originalUri.resolveUri(response.realUri);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have any standards that indicate we should resolve the real dest based on the original one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://www.rfc-editor.org/rfc/rfc7231#section-7.1.2

The field value consists of a single URI-reference. When it has the
form of a relative reference ([RFC3986], Section 4.2), the final
value is computed by resolving it against the effective request URI
([RFC3986], Section 5).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Could you add it as a comment, so we can track it back somedays if we forgot it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@s0nerik

await cookieJar.saveFromResponse(realUri, cookies);
if (isRedirectRequest && locations.isNotEmpty) {
final originalUri = response.realUri;
await Future.wait(
Expand Down