Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved documentation #1957

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Improved documentation #1957

merged 5 commits into from
Sep 18, 2023

Conversation

ueman
Copy link
Contributor

@ueman ueman commented Sep 8, 2023

This adds doc pages to the existing API docs. This is similar to the approach of the docs of GoRouter, see for example the following page: https://pub.dev/documentation/go_router/latest/topics/Get%20started-topic.html

This works by making use of categories (also called topics). See dartdoc explanation at https://pub.dev/packages/dartdoc#advanced-features

How to test this

Execute dart doc in the dio folder. This creates the docs. When opening the index.html, you should see the newly added migration page in the API docs.

Further stops

I'll try to migrate further documentation to, but further I'd like some feedback.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Fixes #1921

@ueman ueman changed the title initial poc Improved documentation Sep 8, 2023
@kuhnroyal
Copy link
Member

Do we need to do anything to deploy this?

@ueman
Copy link
Contributor Author

ueman commented Sep 11, 2023

Do we need to do anything to deploy this?

Nope. This will be part of the hosted API docs on pub.dev

@kuhnroyal
Copy link
Member

Awesome, I ran this locally, looks good!

@ueman ueman marked this pull request as ready for review September 14, 2023 13:16
@ueman ueman requested a review from a team as a code owner September 14, 2023 13:16
@ueman ueman enabled auto-merge September 18, 2023 08:42
@ueman ueman added this pull request to the merge queue Sep 18, 2023
Merged via the queue into main with commit a20f635 Sep 18, 2023
10 checks passed
@ueman ueman deleted the better-docs branch September 18, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Documentation] A website with Detailed Documentation
3 participants