Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve melos configuration #1961

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Improve melos configuration #1961

merged 1 commit into from
Sep 12, 2023

Conversation

kuhnroyal
Copy link
Member

  • mainly rename workspace project to avoid conflicts in IDEA (2x dio project)
  • add examples to melos (not sure if this is what we want?)
  • add .gitignore where missing

@kuhnroyal kuhnroyal self-assigned this Sep 11, 2023
@kuhnroyal kuhnroyal requested a review from a team as a code owner September 11, 2023 12:55
<module fileurl="file://$PROJECT_DIR$/plugins/http2_adapter/melos_dio_http2_adapter.iml" filepath="$PROJECT_DIR$/plugins/http2_adapter/melos_dio_http2_adapter.iml" />
<module fileurl="file://$PROJECT_DIR$/plugins/native_dio_adapter/melos_native_dio_adapter.iml" filepath="$PROJECT_DIR$/plugins/native_dio_adapter/melos_native_dio_adapter.iml" />
<module fileurl="file://$PROJECT_DIR$/melos_dio.iml" filepath="$PROJECT_DIR$/melos_dio.iml" />
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were 2 melos_dio projects in IDEA here which doesn't work. Not sure how this change affects VSCode.

* rename workspace project to avoid conflicts in IDEA (2x dio project)
* add examples to melos
* add .gitignore where missing
Copy link
Member

@AlexV525 AlexV525 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kuhnroyal kuhnroyal added this pull request to the merge queue Sep 12, 2023
Merged via the queue into cfug:main with commit 45b73b2 Sep 12, 2023
@kuhnroyal kuhnroyal deleted the improve/melos branch September 12, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants