Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add talker_dio_logger package in README.md #1969

Merged
merged 6 commits into from
Sep 18, 2023
Merged

Add talker_dio_logger package in README.md #1969

merged 6 commits into from
Sep 18, 2023

Conversation

Frezyx
Copy link
Contributor

@Frezyx Frezyx commented Sep 15, 2023

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@Frezyx Frezyx requested a review from a team as a code owner September 15, 2023 19:34
ueman
ueman approved these changes Sep 16, 2023
View reviewed changes
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nitpick, otherwise LGTM.

dio/README-ZH.md Outdated Show resolved Hide resolved
dio/README.md Outdated Show resolved Hide resolved
Frezyx and others added 2 commits September 17, 2023 02:45
@Frezyx @ueman
Update dio/README.md
e1f93b0 
Co-authored-by: Jonas Uekötter <[email protected]>
Signed-off-by: Stanislav Ilin <[email protected]>
@Frezyx
Update talker_dio_logger description
486453d
@Frezyx
Copy link
Contributor Author

Frezyx commented Sep 16, 2023

Hello @ueman !
I updated the description because the current version was not fully clear.
The talker_dio_logger is built based on talker, but not for it.

What you think about current description ?

@ueman
Copy link
Contributor

ueman commented Sep 17, 2023

Hello @ueman ! I updated the description because the current version was not fully clear. The talker_dio_logger is built based on talker, but not for it.

What you think about current description ?

Yes, that's also good. Thanks!

AlexV525
AlexV525 reviewed Sep 18, 2023
View reviewed changes
dio/README-ZH.md Outdated Show resolved Hide resolved
@Frezyx @AlexV525
Update dio/README-ZH.md
8462c0e 
Co-authored-by: Alex Li <[email protected]>
Signed-off-by: Stanislav Ilin <[email protected]>
@ueman
Copy link
Contributor

ueman commented Sep 18, 2023

@Frezyx Can you resolve the conflicts? Plugins have been moved to their own file

@ueman ueman added this pull request to the merge queue Sep 18, 2023
Merged via the queue into cfug:main with commit 22cfd6b Sep 18, 2023
@AlexV525 AlexV525 added e: documentation Improvements or additions to documentation p: ecosystem Targeting packages that's under the dio's ecosystem labels Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexV525 AlexV525 AlexV525 left review comments

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
e: documentation Improvements or additions to documentation p: ecosystem Targeting packages that's under the dio's ecosystem
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Frezyx @ueman @AlexV525