👷 Add README.md & CHANGELOG.md size check for publishable tests
#1977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, a working example is here: https://github.com/cfug/dio/actions/runs/6269325403/job/17025585341?pr=1977 |
AlexV525
changed the title
CHANGELOG.md size check for publishable testsREADME.md & CHANGELOG.md size check for publishable tests
AlexV525
force-pushed
the
feat/check-changelog-size
branch
from
0c56cae to
554c905
Compare
|
How big are our changelog and readme files right now? |
Quite far from the limit. And now we have separated docs, which decreases the risk of reaching the limit. |
ueman
approved these changes
Sep 22, 2023
Now they are displayed in each run. https://github.com/cfug/dio/actions/runs/6270605319/job/17028785303?pr=1977 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by dart-lang/pub-dev#6012.
New Pull Request Checklist
mainbranch to avoid conflicts (via merge from master or rebase)CHANGELOG.mdin the corresponding package