Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💚 Fix publishing and dry-run #1978

Merged
merged 5 commits into from
Sep 22, 2023
Merged

💚 Fix publishing and dry-run #1978

merged 5 commits into from
Sep 22, 2023

Conversation

AlexV525
Copy link
Member

https://github.com/cfug/dio/actions/runs/6269363038/job/17025684902

Run [[ dart pub publish --dry-run  ]] in dio
Error: Package validation found the following potential issue:
* Rename the top-level "docs" directory to "doc".
  The Pub layout convention is to use singular directory names.
  Plural names won't be correctly identified by Pub and other tools.
  See https://dart.dev/tools/pub/package-layout.
Package validation found the following hint:
* The declared SDK constraint is '>=2.15.0 <3.0.0', this is interpreted as '>=2.15.0 <4.0.0'.
  
  Consider updating the SDK constraint to:
  
  environment:
    sdk: '>=2.15.0 <4.0.0'
  

Package has 1 warning and 1 hint.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

Our dry-run workflows are not running functionally.

@AlexV525 AlexV525 self-assigned this Sep 22, 2023
@AlexV525 AlexV525 requested a review from a team as a code owner September 22, 2023 02:38
@AlexV525 AlexV525 added the 🚒 URGENT Needs to be resolved immediately label Sep 22, 2023
@AlexV525
Copy link
Member Author

Thanks for the great ChatGPT in helping with scripts.

@AlexV525 AlexV525 changed the title 💚 Fix publishing 💚 Fix publishing and dry-run Sep 22, 2023
@AlexV525 AlexV525 merged commit de8f319 into main Sep 22, 2023
34 checks passed
@AlexV525 AlexV525 deleted the fix/publishing branch September 22, 2023 03:07
@AlexV525 AlexV525 added the infra label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infra 🚒 URGENT Needs to be resolved immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant