Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Clean #1981

Merged
merged 7 commits into from
Sep 25, 2023
Merged

🔥 Clean #1981

merged 7 commits into from
Sep 25, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Sep 23, 2023 •
edited
Loading

Here is some cleaning again. :)

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 requested a review from a team as a code owner September 23, 2023 02:55
kuhnroyal
kuhnroyal approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, probably should add a line in the changelog or migration guide about the new map encoding warning.

@AlexV525
Update CHANGELOG.md
8ae7ab2 
Signed-off-by: Alex Li <[email protected]>
@AlexV525 AlexV525 added this pull request to the merge queue Sep 25, 2023
Merged via the queue into main with commit 7c48420 Sep 25, 2023
34 checks passed
@AlexV525 AlexV525 deleted the chore/clean branch September 25, 2023 23:49
@AlexV525 AlexV525 added the p: dio Targeting `dio` package label Oct 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman left review comments

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
p: dio Targeting `dio` package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexV525 @kuhnroyal @ueman