Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🔥 Remove melos_ prefix for IDEA modules #1986

Merged
merged 1 commit into from
Oct 1, 2023
Merged

🔥 Remove melos_ prefix for IDEA modules #1986

merged 1 commit into from
Oct 1, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Oct 1, 2023

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 added the infra label Oct 1, 2023
@AlexV525 AlexV525 requested a review from a team as a code owner October 1, 2023 05:36
AlexV525
AlexV525 commented Oct 1, 2023
View reviewed changes
melos.yaml
Comment on lines 9 to +12
ide:
intellij: true
intellij:
enabled: true
moduleNamePrefix: ''
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core

ueman
ueman approved these changes Oct 1, 2023
View reviewed changes
Copy link
Contributor

@ueman ueman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not a IntelliJ user, so this gets a RSLGTM

@AlexV525
Copy link
Member Author

AlexV525 commented Oct 1, 2023

I’m not a IntelliJ user, so this gets a RSLGTM

Haha, @kuhnroyal would love this

@AlexV525 AlexV525 added this pull request to the merge queue Oct 1, 2023
Merged via the queue into main with commit ea82578 Oct 1, 2023
34 checks passed
@AlexV525 AlexV525 deleted the chore/melos branch October 1, 2023 10:17
@kuhnroyal
Copy link
Member

Gonna check this when I am back from vacation. Didn't know about the prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexV525 @kuhnroyal @ueman