Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Http2 adatper header support dynamic #2043

Merged
merged 8 commits into from
Nov 27, 2023

Conversation

Passer-by
Copy link
Contributor

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@Passer-by Passer-by requested a review from a team as a code owner November 25, 2023 05:11
@Passer-by
Copy link
Contributor Author

Dio's header is of type Map<String, dynamic>, so the Http2Adapter cannot directly convert the value to a string.
But there is a question about this PR: Why does Dio perform a default trim operation on the value? Unlike the native Dart HttpClient, which does not trim when setting headers. Should I adhere to Dio's standard or the Dart HttpClient standard?

@AlexV525
Copy link
Member

Should I adhere to Dio's standard or the Dart HttpClient standard?

Thanks for details. I think we should stick to RFCs instead of Dio's. We'll manage to get rid of the Dio's implementation too.

plugins/http2_adapter/test/http2_test.dart Outdated Show resolved Hide resolved
plugins/http2_adapter/CHANGELOG.md Outdated Show resolved Hide resolved
plugins/http2_adapter/CHANGELOG.md Outdated Show resolved Hide resolved
@AlexV525 AlexV525 added this pull request to the merge queue Nov 27, 2023
Merged via the queue into cfug:main with commit 1e370ab Nov 27, 2023
3 checks passed
@AlexV525 AlexV525 added p: http2_adapter Targeting `http2_adapter` package s: bug Something isn't working labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: http2_adapter Targeting `http2_adapter` package s: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants