Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[http2_adapter] ✨ Support non-TLS connection requests #2044

Merged
merged 3 commits into from
Nov 26, 2023

Conversation

AlexV525
Copy link
Member

Fixes #1983.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 added p: http2_adapter Targeting `http2_adapter` package s: bug Something isn't working labels Nov 25, 2023
@AlexV525 AlexV525 requested a review from a team as a code owner November 25, 2023 17:33
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to worry about redirects between http/https?

@AlexV525
Copy link
Member Author

Do we need to worry about redirects between http/https?

Don't worry, it will create new connections.

@AlexV525 AlexV525 added this pull request to the merge queue Nov 26, 2023
Merged via the queue into main with commit d3ceab2 Nov 26, 2023
3 checks passed
@AlexV525 AlexV525 deleted the fix/http2-non-tls branch November 26, 2023 02:03
@farrukhnajmi
Copy link

@AlexV525 I built my app with latest main and can confirm this fixes the bug my app was encountering. Thank you. When do you think this fix will be released (assuming in 5.3.5 release).

@AlexV525
Copy link
Member Author

AlexV525 commented Nov 27, 2023

@AlexV525 I built my app with latest main and can confirm this fixes the bug my app was encountering. Thank you. When do you think this fix will be released (assuming in 5.3.5 release).

Thanks for your rapid testing. It generally takes days or weeks before we make a new release, depend on the overall status of packages.

@farrukhnajmi

This comment was marked as off-topic.

@AlexV525

This comment was marked as off-topic.

@farrukhnajmi

This comment was marked as off-topic.

@AlexV525
Copy link
Member Author

From your info, there is nothing related to the current session. Please submit new issues with a minimal reproducible example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: http2_adapter Targeting `http2_adapter` package s: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [dio_http2_adapter] WRONG_VERSION_NUMBER tls_record.cc:231
3 participants