Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ Check Uint8List before doing byte conversions #2045

Merged
merged 4 commits into from
Nov 26, 2023
Merged

⚡️ Check Uint8List before doing byte conversions #2045

merged 4 commits into from
Nov 26, 2023

Conversation

AlexV525
Copy link
Member

Prevent Uint8List.fromList if it already is Uint8List.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 added p: dio Targeting `dio` package p: native_dio_adapter Targeting `native_dio_adapter` package e: performance Improvements or additions to performance labels Nov 26, 2023
@AlexV525 AlexV525 requested a review from a team as a code owner November 26, 2023 02:54
kuhnroyal
kuhnroyal approved these changes Nov 26, 2023
View reviewed changes
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added one more location that I had laying around.

@AlexV525
Update CHANGELOG.md
c8bc4a2 
Signed-off-by: Alex Li <[email protected]>
@AlexV525 AlexV525 added this pull request to the merge queue Nov 26, 2023
Merged via the queue into main with commit a7a7878 Nov 26, 2023
3 checks passed
@AlexV525 AlexV525 deleted the feat/uint8-sink branch November 26, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
e: performance Improvements or additions to performance p: dio Targeting `dio` package p: native_dio_adapter Targeting `native_dio_adapter` package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @kuhnroyal