-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve default parameter naming for Interceptor #2047
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would breaks downstream packages' CI since it'll raise warnings about the mismatch naming AFAIK. But it's easy to change the name. Any opinion? @cfug-dev
The PR still lacks of the CHANGELOG update.
Based on my knowledge, the main purpose of parameter naming in aliases is to facilitate code completion in IDEs. It doesn't have any practical impact on other code. Matching names are only required when overriding methods, so I haven't updated the CHANGELOG. Alternatively, should I update my understanding? |
This makes sense. Thanks. |
Improve default parameter naming for Interceptor.
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding packageAdditional context and info (if any)