Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚨 Add dart fix configurations #2049

Merged
merged 5 commits into from
Dec 3, 2023
Merged

🚨 Add dart fix configurations #2049

merged 5 commits into from
Dec 3, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Dec 2, 2023 •
edited
Loading

image

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

https://github.com/flutter/flutter/wiki/Data-driven-Fixes

There are some limitations with dart fix data, such as we cannot modify a method parameter's arguments in a constructor (onHttpClientCreate: (client) to createHttpClient: (), stream to () => stream).

@AlexV525 AlexV525 marked this pull request as ready for review December 3, 2023 10:26
@AlexV525 AlexV525 requested a review from a team as a code owner December 3, 2023 10:26
@AlexV525 AlexV525 enabled auto-merge December 3, 2023 12:13
kuhnroyal
kuhnroyal approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, didn't know this is possible for library authors.

@AlexV525 AlexV525 added this pull request to the merge queue Dec 3, 2023
Merged via the queue into main with commit ff46ffa Dec 3, 2023
0 of 3 checks passed
@AlexV525 AlexV525 deleted the feat/dart-fix branch December 3, 2023 12:43
@AlexV525 AlexV525 added s: feature This issue indicates a feature request e: good for newcomers Good for newcomers labels Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
e: good for newcomers Good for newcomers s: feature This issue indicates a feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @kuhnroyal