Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Fix receiveTimeout for streamed responses #2050

Merged
merged 13 commits into from
Dec 3, 2023

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Dec 3, 2023

Due to httpbun issues, I found a fake test with timeouts which tested with inappropriate queries (wrote duration: instead of duration), and also found an incorrect implementation of the response stream.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

  • Once EventSink is called with add or addError, it cannot be used again to make these calls, but it won't throw exceptions.
  • HttpClient seems reused even if you created a new one.

@AlexV525 AlexV525 added p: dio Targeting `dio` package s: bug Something isn't working platform: io labels Dec 3, 2023
@AlexV525 AlexV525 marked this pull request as ready for review December 3, 2023 10:24
@AlexV525 AlexV525 requested a review from a team as a code owner December 3, 2023 10:24
@AlexV525 AlexV525 added this pull request to the merge queue Dec 3, 2023
Merged via the queue into main with commit aff5760 Dec 3, 2023
3 checks passed
@AlexV525 AlexV525 deleted the fix/receive-timeout-response-stream branch December 3, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p: dio Targeting `dio` package platform: io s: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants