Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥅 Throws precise StateError for handler's duplicated calls #2130

Merged
merged 4 commits into from
Mar 15, 2024
Merged

🥅 Throws precise StateError for handler's duplicated calls #2130

merged 4 commits into from
Mar 15, 2024

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Mar 11, 2024 •
edited
Loading

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@kuhnroyal
Copy link
Member

I will test this tomorrow, had exactly this problem recently.

kuhnroyal
kuhnroyal approved these changes Mar 15, 2024
View reviewed changes
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested this on a bug I experienced last week that caused several hours of pain, this would have helped :)

@kuhnroyal
Copy link
Member

Still needs a changelog.

@AlexV525 AlexV525 marked this pull request as ready for review March 15, 2024 15:58
@AlexV525 AlexV525 requested a review from a team as a code owner March 15, 2024 15:58
@AlexV525 AlexV525 added this pull request to the merge queue Mar 15, 2024
Merged via the queue into main with commit b261a7b Mar 15, 2024
3 checks passed
@AlexV525 AlexV525 deleted the chore/precise-throws-for-handle-duplicated-calls branch March 15, 2024 16:06
@kuhnroyal kuhnroyal mentioned this pull request Mar 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexV525 @kuhnroyal