-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
⚡️ Improve multiple timeout tests #2142
Conversation
Using drip is actually a great idea, didn't think of that! |
drip
for download cancel tests
I've updated the description, this might significantly help with random test failures. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wonder if we should test the connection timeouts with mocks?
Okay so it's not a mock, it happens because the IP is non-reachable in a regular LAN network. We should use the same URL (or something like 192.168.0.0) if we want to make sure that the connection timeouts statically happened. |
drip
to control the overall response duration.New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding package