Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Depends dio_test from any source #2160

Merged
merged 4 commits into from
Mar 26, 2024
Merged

Conversation

AlexV525
Copy link
Member

Let Melos decide where it should be overridden.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 marked this pull request as ready for review March 25, 2024 09:50
@AlexV525 AlexV525 requested a review from a team as a code owner March 25, 2024 09:50
Copy link
Member

@kuhnroyal kuhnroyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hope this works for the release, didn't think of this.

Signed-off-by: Alex Li <[email protected]>
@kuhnroyal
Copy link
Member

The CI problem seems to be some random melos failure?
Not sure about how pub works with dev dependencies, do they need to be valid/existing?

Copy link
Contributor

Code Coverage Report

Package Base Coverage New Coverage Difference
dio 🟢 80.3% 🟢 81% 🟢 0.7%
Overall Coverage 🟢 80.3% 🟢 81% 🟢 0.7%

Minimum allowed coverage is 0%, this run produced 81%

@AlexV525
Copy link
Member Author

do they need to be valid/existing?

Just checked again, and switched to a git dependency which bypass the validation.

@AlexV525 AlexV525 force-pushed the main branch 3 times, most recently from 4d616d5 to 6ad7313 Compare March 26, 2024 02:22
@AlexV525 AlexV525 merged commit 5fdf910 into main Mar 26, 2024
3 checks passed
@AlexV525 AlexV525 deleted the fix/dio-test-dependencies branch March 26, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants