-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transfer more tests to shared test project #2161
Conversation
4d616d5
to
6ad7313
Compare
Code Coverage Report
Minimum allowed coverage is |
https://github.com/cfug/dio/actions/runs/8513054967/job/23315952339#step:15:121 [dio]: ::group::❌ loading test/test_suite_test.dart (failed)
[dio]: Failed to load "test/test_suite_test.dart":
[dio]: ../../../../.pub-cache/git/dio-1c2843a2fab1c3795272df1e81502616761e192e/dio_test/lib/src/test/upload_tests.dart:66:20: Error: No named parameter with the name 'exclusive'.
[dio]: f.createSync(exclusive: false);
[dio]: ^^^^^^^^^
[dio]: ../../../../.pub-cache/git/dio-1c2843a2fab1c3795272df1e81502616761e192e/dio_test/lib/src/test/upload_tests.dart:95:20: Error: No named parameter with the name 'exclusive'.
[dio]: f.createSync(exclusive: false);
[dio]: ^^^^^^^^^ |
I think this is happening due to the git dependency. |
This likely happens on the min SDK because we have to use an old melos version there which seems to no create the overrides correctly. |
We can also remove the |
Yea but that doesn't really fix the issue, only the current symptom. Something else is wrong here, I played around in kuhnroyal#28 and the stable workflow failed with analyzer errors that I have fixed in the same PR. Like it is analyzing an older dio version. Not sure. In any case, the http package is doing using a similar approach and they have their test package in the main pubspec as path dependency: https://github.com/dart-lang/http/blob/master/pkgs/http/pubspec.yaml |
This PR transfers some download and header/options tests to the shared test project and thus enabled them for the Http2 adapter.
New Pull Request Checklist
main
branch to avoid conflicts (via merge from master or rebase)CHANGELOG.md
in the corresponding packageAdditional context and info (if any)