Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually run all test in the baseline 🙈 #2234

Merged
merged 1 commit into from
Jun 6, 2024
Merged

Conversation

kuhnroyal
Copy link
Member

Trying to fix the wrong coverage for http2 plugin.

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

Additional context and info (if any)

@kuhnroyal kuhnroyal self-assigned this Jun 6, 2024
@kuhnroyal
Copy link
Member Author

I don't understand this, locally I get the same coverage as in the baseline.

@kuhnroyal kuhnroyal changed the title Attempt to clear coverage files before next run Actually run all test in the baseline 🙈 Jun 6, 2024
@kuhnroyal kuhnroyal marked this pull request as ready for review June 6, 2024 13:01
@kuhnroyal kuhnroyal requested a review from a team as a code owner June 6, 2024 13:01
@kuhnroyal
Copy link
Member Author

Nvm, found it...
After this is merged, we should have a correct baseline.

Copy link
Contributor

github-actions bot commented Jun 6, 2024

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
plugins/http2_adapter/lib/src/connection_manager_imp.dart 🟠 60.47% 🟢 79.84% 🟢 19.37%
Overall Coverage 🟢 80.48% 🟢 81.41% 🟢 0.93%

Minimum allowed coverage is 0%, this run produced 81.41%

@kuhnroyal kuhnroyal merged commit 005251d into cfug:main Jun 6, 2024
3 checks passed
@kuhnroyal kuhnroyal deleted the coverage branch June 6, 2024 15:53
@AlexV525
Copy link
Member

AlexV525 commented Jun 7, 2024

I've been seeing the same exception multiple times, is that a known issue?

https://github.com/cfug/dio/actions/runs/9404023625/job/25901960393

@kuhnroyal
Copy link
Member Author

Yea, this is likely related to the old melos version that we have to use on min SDK.

@AlexV525
Copy link
Member

AlexV525 commented Jun 7, 2024

Yea, this is likely related to the old melos version that we have to use on min SDK.

Ah I remember I saw the same reply from you somewhere before, damn...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants