Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Applies strict type conversion for finalizing the multipart file #2237

Merged
merged 4 commits into from
Jun 8, 2024

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jun 7, 2024

Fixes #2236

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 marked this pull request as ready for review June 7, 2024 13:58
@AlexV525 AlexV525 requested a review from a team as a code owner June 7, 2024 13:58
Copy link
Contributor

github-actions bot commented Jun 7, 2024

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
dio/lib/src/multipart_file.dart 🟢 88.57% 🟢 88.89% 🟢 0.32%
Overall Coverage 🟢 81.41% 🟢 81.28% 🔴 -0.13%

Minimum allowed coverage is 0%, this run produced 81.28%

@AlexV525
Copy link
Member Author

AlexV525 commented Jun 7, 2024

If the only precise coverage diff is positive, how would the overall coverage diff become negative? :D

@kuhnroyal
Copy link
Member

I have no idea...

@AlexV525 AlexV525 merged commit d334d25 into main Jun 8, 2024
3 checks passed
@AlexV525 AlexV525 deleted the fix/multipart-file-type-conversion branch June 8, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uploading with FormData throws a TypeError: type 'List<int>' is not a subtype of type 'Uint8List' of 'value'
2 participants