Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡️ Deallocate operations and requests for cancellation #2252

Merged
merged 19 commits into from
Jul 3, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
♻️ Move cancelable operation into the core
  • Loading branch information
AlexV525 committed Jun 20, 2024
commit 4b756d0a8ed812ea8e2ffcaf015d2f85c173e0e2
11 changes: 1 addition & 10 deletions dio/lib/src/adapters/io_adapter.dart
Original file line number Diff line number Diff line change
@@ -2,8 +2,6 @@ import 'dart:async';
import 'dart:io';
import 'dart:typed_data';

import 'package:async/async.dart';

import '../adapter.dart';
import '../dio_exception.dart';
import '../options.dart';
@@ -70,14 +68,7 @@ class IOHttpClientAdapter implements HttpClientAdapter {
"Can't establish connection after the adapter was closed.",
);
}
final operation = CancelableOperation.fromFuture(
_fetch(options, requestStream, cancelFuture),
);
final wr = WeakReference<CancelableOperation<ResponseBody>>(operation);
cancelFuture?.whenComplete(() {
wr.target?.cancel();
});
return operation.value;
return _fetch(options, requestStream, cancelFuture);
}

Future<ResponseBody> _fetch(
16 changes: 12 additions & 4 deletions dio/lib/src/dio_mixin.dart
Original file line number Diff line number Diff line change
@@ -4,6 +4,7 @@ import 'dart:convert';
import 'dart:math' as math;
import 'dart:typed_data';

import 'package:async/async.dart';
import 'package:meta/meta.dart';

import 'adapter.dart';
@@ -524,11 +525,18 @@ abstract class DioMixin implements Dio {
final cancelToken = reqOpt.cancelToken;
try {
final stream = await _transformData(reqOpt);
final responseBody = await httpClientAdapter.fetch(
reqOpt,
stream,
cancelToken?.whenCancel,
final operation = CancelableOperation.fromFuture(
httpClientAdapter.fetch(
reqOpt,
stream,
cancelToken?.whenCancel,
),
);
final operationWeakReference = WeakReference(operation);
cancelToken?.whenCancel.whenComplete(() {
operationWeakReference.target?.cancel();
});
final responseBody = await operation.value;
final headers = Headers.fromMap(
responseBody.headers,
preserveHeaderCase: reqOpt.preserveHeaderCase,
2 changes: 1 addition & 1 deletion dio/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -20,7 +20,7 @@ environment:
sdk: '>=2.18.0 <4.0.0'

dependencies:
async: ^2.11.0
async: ^2.8.2
http_parser: ^4.0.0
meta: ^1.5.0
path: ^1.8.0
10 changes: 1 addition & 9 deletions plugins/http2_adapter/lib/src/http2_adapter.dart
Original file line number Diff line number Diff line change
@@ -3,7 +3,6 @@ import 'dart:convert';
import 'dart:io';
import 'dart:typed_data';

import 'package:async/async.dart';
import 'package:dio/dio.dart';
import 'package:dio/io.dart';
import 'package:http2/http2.dart';
@@ -49,14 +48,7 @@ class Http2Adapter implements HttpClientAdapter {
) {
// Recursive fetching.
final redirects = <RedirectRecord>[];
final operation = CancelableOperation.fromFuture(
_fetch(options, requestStream, cancelFuture, redirects),
);
final wr = WeakReference<CancelableOperation<ResponseBody>>(operation);
cancelFuture?.whenComplete(() {
wr.target?.cancel();
});
return operation.value;
return _fetch(options, requestStream, cancelFuture, redirects);
}

Future<ResponseBody> _fetch(
1 change: 0 additions & 1 deletion plugins/http2_adapter/pubspec.yaml
Original file line number Diff line number Diff line change
@@ -15,7 +15,6 @@ environment:
sdk: ">=3.0.0 <4.0.0"

dependencies:
async: ^2.11.0
dio: ^5.2.0
http2: ^2.1.0
meta: ^1.9.1