Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🥅 Catch MediaType parse exception in Transformer.isJsonMimeType #2257

Merged
merged 5 commits into from
Jun 25, 2024
Merged

🥅 Catch MediaType parse exception in Transformer.isJsonMimeType #2257

merged 5 commits into from
Jun 25, 2024

Conversation

AlexV525
Copy link
Member

Resolve #2256

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 requested a review from a team as a code owner June 25, 2024 07:58
@AlexV525 AlexV525 changed the title 🥅 Catch MediaType parse exception 🥅 Catch MediaType parse exception in Transformer.isJsonMimeType Jun 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
dio/lib/src/transformer.dart 🟢 84% 🟢 84.62% 🟢 0.62%
Overall Coverage 🟢 82.49% 🟢 82.51% 🟢 0.02%

Minimum allowed coverage is 0%, this run produced 82.51%

@AlexV525
Copy link
Member Author

Thanks guys!

@AlexV525 AlexV525 merged commit 224db94 into main Jun 25, 2024
3 checks passed
@AlexV525 AlexV525 deleted the fix/transformer-is-json-mime-type branch June 25, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CaiJingLong CaiJingLong CaiJingLong approved these changes

@ueman ueman ueman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transformer.isJsonMimeType throws format exceptions without caught
3 participants
@AlexV525 @ueman @CaiJingLong