Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🧑‍💻 Move logs out from the adapter #2260

Merged
merged 3 commits into from
Jul 1, 2024
Merged

🧑‍💻 Move logs out from the adapter #2260

merged 3 commits into from
Jul 1, 2024

Conversation

AlexV525
Copy link
Member

@AlexV525 AlexV525 commented Jul 1, 2024

Resolves #2255

New Pull Request Checklist

  • I have read the Documentation
  • I have searched for a similar pull request in the project and found none
  • I have updated this branch with the latest main branch to avoid conflicts (via merge from master or rebase)
  • I have added the required tests to prove the fix/feature I'm adding
  • I have updated the documentation (if necessary)
  • I have run the tests without failures
  • I have updated the CHANGELOG.md in the corresponding package

@AlexV525 AlexV525 requested a review from a team as a code owner July 1, 2024 02:46
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2024

Code Coverage Report: Only Changed Files listed

Package Base Coverage New Coverage Difference
dio/lib/src/options.dart 🟢 91.94% 🟢 89.53% 🔴 -2.41%
Overall Coverage 🟢 82.48% 🟢 82.29% 🔴 -0.19%

Minimum allowed coverage is 0%, this run produced 82.29%

@AlexV525 AlexV525 merged commit eb1684e into main Jul 1, 2024
3 checks passed
@AlexV525 AlexV525 deleted the chore/move-web-warnings branch July 1, 2024 15:07
@tomwyr tomwyr mentioned this pull request Oct 23, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuhnroyal kuhnroyal kuhnroyal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🔔 Dio] sendTimeout cannot be used without a request body to send
2 participants
@AlexV525 @kuhnroyal