Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stores-bitcoin - balance query #1343

Open
wants to merge 14 commits into
base: Thunnini/bitcoin
Choose a base branch
from
Open

stores-bitcoin - balance query #1343

wants to merge 14 commits into from
+575 −37

Conversation

piatoss3612
Copy link
Collaborator

@piatoss3612 piatoss3612 commented Feb 27, 2025 •
edited
Loading

1. bitcoin chain info

  • testnet, signet indexer url 추가
  • �currencies 필드 추가

coinMinimalDenom은 ibc, erc20 같이 체인 이름 옆에 표시되도록 구성을 해보았는데, 따로 식별자를 추가하는 게 좋을까요?

2. stores-bitcoin 라이브러리 추가

  • BitcoinAccountStore는 베이스만 잡아놓았습니다
  • ObservableBitcoinIndexerQuery 정의
  • ObservableQueryBitcoinBalance 구현

balance 값은 우선 mempool에 있는 utxo도 포함하도록 계산했습니다

3. ChainStore 수정

  • bitcoin currencies 등록 가능하게 수정

4. available 탭에서 밸런스 보여주기

  • HugeQueriesStore에 BitcoinQueriesStore 추가
  • 체인 및 btc 자산도 검색 가능하도록 수정
스크린샷 2025-02-28 오후 2 56 59

5. token details 페이지

스크린샷 2025-02-28 오후 2 58 49

@vercel Vercel
Copy link

vercel bot commented Feb 27, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keplr-wallet-extension ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 0:26am

@piatoss3612 piatoss3612 changed the base branch from Thunnini/bitcoin to rowan/KEPLR-844 February 27, 2025 05:29
@piatoss3612 piatoss3612 changed the title stores-bitcoin implementation stores-bitcoin - balance query Feb 28, 2025
@piatoss3612 piatoss3612 changed the base branch from rowan/KEPLR-844 to Thunnini/bitcoin February 28, 2025 06:38
@piatoss3612 piatoss3612 marked this pull request as ready for review February 28, 2025 06:56
delivan
delivan approved these changes Feb 28, 2025
View reviewed changes
Copy link
Member

@delivan delivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delivan delivan delivan approved these changes

@Thunnini Thunnini Awaiting requested review from Thunnini

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@piatoss3612 @delivan