Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Actually return & use StDiff #1964

Open
wants to merge 3 commits into
base: rnd/stateful-statediff
Choose a base branch
from
Open

[WIP] Actually return & use StDiff #1964

wants to merge 3 commits into from

Conversation

kpp
Copy link
Contributor

@kpp kpp commented Feb 22, 2025 •
edited
Loading

Description

  • Move StDiff into rollup-interface to be able to use StatefulStateDiff type in core/modules/runners.
  • Implement StDiff::merge operation
  • Actually return and use StDiff in our rollup

Linked Issues

@kpp kpp requested a review from eyusufatik as a code owner February 22, 2025 17:35
@auto-assign auto-assign bot requested a review from ercecan February 22, 2025 17:35
@kpp kpp changed the title Move StDiff into rollup-interface [WIP] Move StDiff into rollup-interface Feb 24, 2025
@kpp kpp changed the title [WIP] Move StDiff into rollup-interface [WIP] Actually return & use StDiff Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakanalh rakanalh rakanalh approved these changes

@eyusufatik eyusufatik eyusufatik approved these changes

@ercecan ercecan Awaiting requested review from ercecan

Assignees

@kpp kpp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpp @rakanalh @eyusufatik