Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move tableInfoStore to the transaction #245

Closed
wants to merge 1 commit into from
Closed

Move tableInfoStore to the transaction #245

wants to merge 1 commit into from

Conversation

tie
Copy link
Contributor

@tie tie commented Oct 9, 2020

Using tableInfoStore in database.Database is unsafe since we can’t guarantee the consistency of the underlying database engine outside of the transaction.

Fixes #243

@tie tie mentioned this pull request Oct 18, 2020
Closed
@asdine asdine changed the base branch from master to main November 14, 2020 11:29
@asdine
Copy link
Collaborator

asdine commented Nov 14, 2020

@tie Closing this in favor of #322 which removes the in-memory tableInfoStore entirely.
Thanks!

@asdine asdine closed this Nov 14, 2020
@tie tie deleted the fix-table-info-store branch May 13, 2021 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tableInfoStore should be scoped to transaction
2 participants
@tie @asdine