Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] go-orm proof of concept example #390

Closed
wants to merge 1 commit into from

Conversation

paralin
Copy link

@paralin paralin commented Apr 18, 2021

Currently fails due to issue #383

This is a proof-of-concept of constructing a Go-orm instance backed by GenjiDB.

Signed-off-by: Christian Stewart <[email protected]>
@paralin
Copy link
Author

paralin commented Apr 23, 2021

https://github.com/paralin/genji/tree/gorm-example-mysql-dialect

Here's a variant which uses the mysql dialect instead of the sqlite one. I think AUTO_INCREMENT is not supported (right?) so that part is disabled.

@asdine
Copy link
Collaborator

asdine commented Apr 29, 2021

Thanks @paralin ! I would love to make Genji compatible with Gorm! I think what you did is more than just an example and deserves a separate repo. I propose to create a repo in the genjidb org so then you can create a PR there, what do you think?

@paralin
Copy link
Author

paralin commented May 30, 2021

@asdine Sorry never saw your reply for some reason, whatever you want to do with this example / demo, let me know.

@asdine
Copy link
Collaborator

asdine commented Jul 2, 2022

@paralin Sorry for the very late reply, I am going to close this PR for now until we have enough features to make it compatible with go-orm. When that's the case we will re-open this PR and reuse the work you've done.
Thanks!

@asdine asdine closed this Jul 2, 2022
@paralin
Copy link
Author

paralin commented Jul 2, 2022

I think there are enough features to make it work; at least last time I tried it

But I'd have to spend some time digging through the code to figure out how I made it work.

If anyone really needs this urgently feel free to ping here and I'll see if I can post a repro.

@asdine
Copy link
Collaborator

asdine commented Jul 3, 2022

@paralin There is no rush, I don't yet have time to tackle this issue, if you want to do it let me know at anytime and I'll re-open it and answer any question you may have

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants