fix(tags-input): ignore key during composition in onKeyDown event (#…

…805) Co-authored-by: Segun Adebayo <[email protected]>
chakra-ui · Aug 16, 2023 · a698f23 · a698f23 · vercel · Aug 16, 2023
1 parent db81eaa
commit a698f23
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/.changeset/mean-items-act.md b/.changeset/mean-items-act.md
@@ -0,0 +1,5 @@
+---
+"@zag-js/tags-input": patch
+---
+
+Ignore key during composition in `onKeyDown` event
diff --git a/packages/machines/tags-input/src/tags-input.connect.ts b/packages/machines/tags-input/src/tags-input.connect.ts
@@ -123,6 +123,9 @@ export function connect<T extends PropTypes>(state: State, send: Send, normalize
         send({ type: "PASTE", value })
       },
       onKeyDown(event) {
+        const evt = getNativeEvent(event)
+        if (evt.isComposing) return
+
         // handle composition when used as combobox
         const target = event.currentTarget as HTMLElement
         const isCombobox = target.getAttribute("role") === "combobox"