Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP]Upgrade to Phoenix 1.4 #127

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

aonomike
Copy link
Collaborator

Fixes #125

@aonomike
Copy link
Collaborator Author

@dkuku
Copy link
Contributor

dkuku commented Jan 29, 2019

Hi @aonomike - I switched to your branch and all tests are running fine but when I open the site the main css file is missing, is it looking ok on yours ?
I think you're missing sass-loader - there were some packages previously with brunch that were compiling scss but I can't see anything in the new package.json or webpack config that compiles the scss files

2019-01-29-030134_1920x2130_scrot

@aonomike
Copy link
Collaborator Author

aonomike commented Feb 2, 2019

't

@dkuku yeah, there was something with the webpack not loading the scss. I have added the css_loader but still the css does not seem to load. Do you have time we can pair on this?

@dkuku
Copy link
Contributor

dkuku commented Feb 2, 2019 via email

@FedericoEsparza
Copy link
Member

Hey @aonomike and @dkuku, @harshdeepkanhai also offered to help out, because he's working on the upgrade on the sing_for_needs backend: https://github.com/AgileVentures/sing_for_needs/pull/7/files

You might want to look at his changes and coordinate with him. It's not passing sing_for_needs's CI, by the way, because the travis file is super basic, right now. We have a ticket to get it close to championer_one's travis file: Update the travis file for CI, if anyone wants to knock it out.

@ghost ghost assigned FedericoEsparza Feb 27, 2019
Copy link
Member

@FedericoEsparza FedericoEsparza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aonomike Is this ready to be reviewed or is it still [WIP]?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants