-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP]Upgrade to Phoenix 1.4 #127
base: develop
Are you sure you want to change the base?
Conversation
- Followed [this link](https://gist.github.com/chrismccord/bb1f8b136f5a9e4abc0bfc07b832257e)
Hi @aonomike - I switched to your branch and all tests are running fine but when I open the site the main css file is missing, is it looking ok on yours ? |
@dkuku yeah, there was something with the webpack not loading the scss. I have added the css_loader but still the css does not seem to load. Do you have time we can pair on this? |
maybe tomorrow,I'll let you know
…On Sat, 2 Feb 2019, 20:02 Mike Aono ***@***.*** wrote:
't
@dkuku <https://github.com/dkuku> yeah, there was something with the
webpack not loading the scss. I have added the css_loader but still the css
does not seem to load. Do you have time we can pair on this?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#127 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA3L83rrWsgcfuJMzO0O8V7UCx6jbIf5ks5vJe66gaJpZM4aQUv5>
.
|
Hey @aonomike and @dkuku, @harshdeepkanhai also offered to help out, because he's working on the upgrade on the You might want to look at his changes and coordinate with him. It's not passing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aonomike Is this ready to be reviewed or is it still [WIP]
?
Fixes #125