Add Workspace name validation (#834) #1068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, that looks great to me, I meant to do that multiple times. Would you mind adding an entry to the CHANGELOG please. |
morucci
reviewed
Oct 2, 2023
There was a problem hiding this comment.
Thanks for the contribution that looks great ! I did a quick manual test trying to load config with wrong index names and the errors are well detected.
Would you like to fix the lint issue and add the changelog entry as suggested by @TristanCacqueray ?
TristanCacqueray
approved these changes
Oct 2, 2023
morucci
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.